-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from drone to Github Actions #133
Conversation
3d3dee8
to
ef0641e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me overall, and I have one request for changes:
could you add the permissions to each job? AFAIK, all jobs need the permission contents: read
to prevent privilege escalation, and the job that reads the credential needs the permission id-token: write
(see example here).
43c92c9
to
0a32c58
Compare
@jiaqiluo Thanks for pointing that out. Have updated permissions for the jobs. Also, do you know if we need to use the containerized runners specified by EIO? |
7ba8ec8
to
8cb7c6a
Compare
8cb7c6a
to
ca094cd
Compare
Hi @mitulshah-suse, you continue using the GitHub provided ones. |
needs: validate | ||
runs-on: ubuntu-latest | ||
timeout-minutes: 90 | ||
if: github.event_name == 'pull_request' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm generally a fan of creating multiple workflow files for different actions. For example, one for PRs, another for merges and one for tagging. IMO that pattern is easier to read and maintain, gets rid of skipped
checks in the github UI when raising PRs, and allows us to avoid the use of if
statements depending on what action is invoking the workflow. Adding conditionals like this can make it harder to determine what should and shouldn't execute given a particular on
statement.
I don't work with this repo often, so I won't hold up this PR based off this, but it's something that should be considered.
Move from drone to GHA.
ref: SURE-7991