Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clusterdns for dualStack #375

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Fix clusterdns for dualStack #375

merged 1 commit into from
Oct 2, 2023

Conversation

manuelbuil
Copy link
Contributor

@manuelbuil manuelbuil commented Oct 2, 2023 •
edited
Loading

This PR mimics the k3s behaviour:

  • If clusterDNS has more than 1 IP, then IPFamily=PreferDualStack. If not IPFamily=SingleStack
  • clusterIP will be the first value set in clusterDNS

@manuelbuil manuelbuil requested a review from a team as a code owner October 2, 2023 06:54
@manuelbuil
Fix clusterdns for dualStack
d13d091 
Signed-off-by: Manuel Buil <[email protected]>
@manuelbuil manuelbuil merged commit 90bbbc4 into rancher:main-source Oct 2, 2023
1 check passed
@manuelbuil manuelbuil deleted the coreDnsDS branch October 2, 2023 14:31
github-actions bot pushed a commit that referenced this pull request Oct 2, 2023
@actions-user
Merge pull request #375 from manuelbuil/coreDnsDS
36be8e6 
Fix clusterdns for dualStack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasferrandiz thomasferrandiz thomasferrandiz approved these changes

@rbrtbnfgl rbrtbnfgl rbrtbnfgl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuelbuil @rbrtbnfgl @thomasferrandiz