Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.7] Add a Workflow That Verifies Changes #122

Merged
merged 1 commit into from
Apr 1, 2024
Merged

[2.7] Add a Workflow That Verifies Changes #122

merged 1 commit into from
Apr 1, 2024

Conversation

caliskanugur
Copy link
Member

Adds a workflow that:

  • Verifies mod file changes
  • Builds packages inside pkg, client, and extensions dirs
  • Uses golangci-lint to check linter issues

Triggers on:

  • Every push (merges in this case)
  • And when a pull request opens targeting release/* or main

@caliskanugur caliskanugur mentioned this pull request Mar 22, 2024
Merged
@caliskanugur caliskanugur added the automation-enhancement To indicate this is related to enhancements in code related to automation label Mar 22, 2024
@caliskanugur caliskanugur force-pushed the qa-issue-1230-2.7 branch 4 times, most recently from b5a91c3 to da90579 Compare March 25, 2024 19:48
@caliskanugur
Add a workflow that checks lint, build and go mod. On every repo push
974ec38 
and pull requestas to main and release branches.
igomez06
igomez06 approved these changes Apr 1, 2024
View reviewed changes
Copy link

@igomez06 igomez06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igomez06 igomez06 merged commit c82002d into rancher:release/v2.7 Apr 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igomez06 igomez06 igomez06 approved these changes

@floatingman floatingman floatingman approved these changes

@sowmyav27 sowmyav27 Awaiting requested review from sowmyav27

Assignees
No one assigned
Labels
automation-enhancement To indicate this is related to enhancements in code related to automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caliskanugur @floatingman @igomez06