Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.8] make out-of-tree helpers public for additional testing during upgrades #143

Merged
merged 1 commit into from
Apr 5, 2024
Merged

[2.8] make out-of-tree helpers public for additional testing during upgrades #143

merged 1 commit into from
Apr 5, 2024

Conversation

slickwarren
Copy link
Contributor

port of #74

@slickwarren slickwarren requested a review from igomez06 April 5, 2024 17:09
igomez06
igomez06 approved these changes Apr 5, 2024
View reviewed changes
Copy link

@igomez06 igomez06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slickwarren slickwarren added area/release-testing Related to Release Testing automation-enhancement To indicate this is related to enhancements in code related to automation labels Apr 5, 2024
@markusewalker markusewalker self-requested a review April 5, 2024 21:16
markusewalker
markusewalker approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@markusewalker markusewalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igomez06 igomez06 changed the title [2.8] out of tree migration [2.8] make out-of-tree helpers public for additional testing during upgrades Apr 5, 2024
@igomez06 igomez06 merged commit 578908d into rancher:release/v2.8 Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusewalker markusewalker markusewalker approved these changes

@igomez06 igomez06 igomez06 approved these changes

Assignees
No one assigned
Labels
area/release-testing Related to Release Testing automation-enhancement To indicate this is related to enhancements in code related to automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slickwarren @igomez06 @markusewalker