Enable creating a rancher client by directly passing a *Config #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
Problem
It is not currently possible to create a rancher Client without relying on Shepherd's configuration file load mechanism which generates Config structs as needed.
Solution
Small refactor to the rancher client's
client.go
which pulls out the majority of the client creation logic into a separate function and adds theNewClientForConfig
function which takes a *Config directly.Testing
Tested locally within the rancher/dartboard project, but have not run any existing tests elsewhere.
Regressions Considerations
There should be no regressions as the flow of the
NewClient
function has not been modified.Backports: