Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.9] Generic Permutations #325

Merged
merged 1 commit into from
Oct 25, 2024
Merged

[2.9] Generic Permutations #325

merged 1 commit into from
Oct 25, 2024

Conversation

susesgartner
Copy link
Contributor

backport of #279

@susesgartner
initial commit
bda927a 
Add LoadConfigFromFile

Move config ops to a seperate file

fix typo

Update permutations.go

Update permutations.go

Update configoperations.go

Update permutations.go

Update configoperations.go

Create example_test.go

Update example_test.go

Update to address PR comments

Update example_test.go

update with correct locations

update directory location

update naming
caliskanugur
caliskanugur approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@caliskanugur caliskanugur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caliskanugur caliskanugur merged commit cd31916 into rancher:release/v2.9 Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusewalker markusewalker markusewalker approved these changes

@Josh-Diamond Josh-Diamond Josh-Diamond approved these changes

@caliskanugur caliskanugur caliskanugur approved these changes

@slickwarren slickwarren slickwarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@susesgartner @slickwarren @caliskanugur @Josh-Diamond @markusewalker