Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Add cluster.cattle.io and RBAC Controllers, Add Missing Import and Session Replaces to the Missing Controllers #328

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[main] Add cluster.cattle.io and RBAC Controllers, Add Missing Import and Session Replaces to the Missing Controllers #328

wants to merge 2 commits into from

Conversation

caliskanugur
Copy link
Member

Issue: #202 & #326 & #327

Problem

RBAC and cluster.cattle.io controllers were missing, as well as some controllers' replaces for session and imports

Solution

Add RBAC and cluster.cattle.io controllers, add missing map items for the path walks

@caliskanugur
Copy link
Member Author

Backports:

floatingman
floatingman approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@floatingman floatingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joesims22
joesims22 approved these changes Oct 28, 2024
View reviewed changes
Copy link

@joesims22 joesims22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joesims22 joesims22 joesims22 approved these changes

@anupama2501 anupama2501 anupama2501 approved these changes

@floatingman floatingman floatingman approved these changes

@dasarinaidu dasarinaidu Awaiting requested review from dasarinaidu

@Priyashetty17 Priyashetty17 Awaiting requested review from Priyashetty17

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caliskanugur @floatingman @anupama2501 @joesims22