Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of catalog v1,MCA #334

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

rohitsakala
Copy link
Member

@caliskanugur
Copy link
Member

Can we get a rebase and squash before we merge this one?

@rohitsakala rohitsakala force-pushed the removal-of-catalog-v1 branch from 0c24dd6 to c01eb6e Compare November 6, 2024 19:33
@caliskanugur
Copy link
Member

caliskanugur commented Nov 6, 2024

LGTM, Can we squash commits as well? Then it should be good to go

@rohitsakala rohitsakala force-pushed the removal-of-catalog-v1 branch from 1eaaa44 to ca7c853 Compare November 26, 2024 19:14
Copy link
Member

@caliskanugur caliskanugur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@caliskanugur caliskanugur merged commit 5be627a into rancher:main Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants