Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Updated const for corral-packge conflict on naming #337

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[main] Updated const for corral-packge conflict on naming #337

wants to merge 1 commit into from

Conversation

MSpencer87
Copy link
Contributor

@MSpencer87 MSpencer87 commented Oct 31, 2024 •
edited
Loading

Problem

Conflict between airgap and proxy corral-packages on name for bastion/registry

Solution

renamed to utilize "bastion" over "registry" in corral-package/shepherd

Testing

Jenkins runs for proxy tests

Regressions Considerations

custom cluster provisioning on airgap setup in jenkins

markusewalker
markusewalker previously approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@markusewalker markusewalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you open backports as well?

@markusewalker markusewalker self-requested a review November 1, 2024 16:19
This was referenced Nov 1, 2024
Open
Open
Open
markusewalker
markusewalker previously approved these changes Nov 1, 2024
View reviewed changes
slickwarren
slickwarren previously approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@slickwarren slickwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo this should be an action, not an extension. since we're already touching the code maybe it would make sense to move it now. Since this is only used for proxy tests.

@MSpencer87 MSpencer87 dismissed stale reviews from slickwarren and markusewalker via 94bd94f December 6, 2024 22:30
@MSpencer87 MSpencer87 requested a review from bmdepesa as a code owner December 6, 2024 22:30
caliskanugur
caliskanugur reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@caliskanugur caliskanugur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just have one nit

clients/corral/corral.go
corralPublicSSHKey = "corral_public_key"
corralRegistryIP = "registry_ip"
corralRegistryPrivateIP = "registry_private_ip"
debugFlag = "--trace"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one just updated to be the debug flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caliskanugur caliskanugur caliskanugur left review comments

@markusewalker markusewalker markusewalker left review comments

@slickwarren slickwarren slickwarren left review comments

@bmdepesa bmdepesa Awaiting requested review from bmdepesa bmdepesa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MSpencer87 @slickwarren @caliskanugur @markusewalker