Add harvester Client #351
Merged
Add harvester Client #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slickwarren
force-pushed
the
cwarren/harvester-client
branch
2 times, most recently
from
3c71a80 to
3e4b144
Compare
slickwarren
force-pushed
the
cwarren/harvester-client
branch
from
3e4b144 to
e44a6b6
Compare
anupama2501
approved these changes
Dec 2, 2024
caliskanugur
approved these changes
Dec 5, 2024
|
yes we will need backports, I wanted to wait for your review to open them 👍🏼 I'll do that now. |
This was referenced Dec 5, 2024
Merged
Merged
removing unnecessary functions from the harvester client
slickwarren
force-pushed
the
cwarren/harvester-client
branch
from
e44a6b6 to
da2238c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
rancher/qa-tasks#468
Problem
currently, we don't have a way to write automation for harvester using the framework.
Solution
harvester's API is based on rancher's steve. In this PR I've introduced a harvester client that wraps steve and catalog clients, introduced a new harvesterConfig, similar to how rancherClient is setup.
We played around with wrapping Steve's API/client directly, but since harvester will need the catalog client as well, giving harvester its own client makes more sense in the long run + to support any use cases their team may have.
Also played around with simplifying the copy-paste logic between rancher and now harvester clients. But this may make more sense to do if we have to introduce another client that uses most of rancher's API which I don't know of a product that would need it tbh. If this approach were taken, the code would be refactored instead of net-new, risking stuff breaking.
Testing
see linked rancher PR; we are now able to use harvester's API and import an existing harvester cluster into an existing rancher setup.
Regressions Considerations
TODO
this is a new client, so no risk of regression.