feat(cluster): add use_instance_metadata_hostname flag to cloud_provider block #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kkaempf I would appreciate you review on this change |
|
passing on ... 😉 |
sriddell
pushed a commit
to sriddell/terraform-provider-rancher2
that referenced
this pull request
Feb 1, 2024
|
Hi @snasovich, it would be great if you can take a look at this change? |
|
This branch was checked out of the v3.1.1 tag, can we merge this fix to v4 and cherry-pick it to v3? |
|
Any progress here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes: rancher/rancher#41059
Problem
Since Rancher v2.6.11 it is now mandatory in some cases for RKE clusters in AWS to set a newly introduced config named useInstanceMetadataHostname.
Upgrading from Rancher v2.6.10 to v2.6.11 will break the clusters if you don't specify this flag.
Solution
Adding the ability to configure the
useInstanceMetadataHostnamefrom therancher2_cluster.rke_config.cloud_providerblock.Testing
Setting the flag to
trueshould result in cluster nodes named using the EC2 instance metadata hostname.Engineering Testing
Manual Testing
Manually checked rancher's api call with the useInstanceMetadataHostname flag present.
Automated Testing
Added a check to the unit test that the flag is persisted and passed as expected.
QA Testing Considerations
Regressions Considerations