Add search option exact_match for data source rancher2_principal #1331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1330
Problem
When using the data source rancher2_principal to search for an LDAP user, sometimes it returns the wrong result if the inputted name has multiple matched results.
Solution
Because the provider picks first element in the list returned from Rancher API. But that list
is unsorted or just in random order, therefore, picking the first element is not the best way. We should loop through it to find the exact match, but changing the default behavior can break compatibility.
So I decided to add an option
exact_match
to control this behavior.Testing
Set option
exact_match=true
must only return an exactly matched user as the inputted nameEngineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations