Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RKE2 vSphere case to E2E suite #610

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

alexander-demicev
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I understand we can only run this locally through the VPN, is that correct?

@alexander-demicev
Copy link
Member Author

@salasberryfin yes, I opened an issue #612 for creating a runner to be able to include tests in the nightly testing

Copy link
Contributor

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-demicev Can you please provide instructions to get VPN access?

@alexander-demicev
Copy link
Member Author

@Danil-Grigorev I replied to your comment privately.

@alexander-demicev alexander-demicev merged commit 02e58b9 into rancher:main Jul 24, 2024
15 of 16 checks passed
@alexander-demicev alexander-demicev deleted the rke2vsphere branch July 24, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants