[etcd-snapshot-restore] Aggregated ETCD snapshot #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
changed the title
Signed-off-by: Danil-Grigorev <[email protected]>
Danil-Grigorev
force-pushed
the
aggregated-etcd-snapshot
branch
from
1b26511
to
1758e5b
Compare
charts/rancher-turtles/templates/rancher-turtles-exp-etcdrestore-components.yaml
Show resolved
Hide resolved
alexander-demicev
approved these changes
Nov 11, 2024
furkatgofurov7
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
LGTM, except the review comments by @salasberryfin earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
From #764:
This allows to maintain an up-to-date per-cluster snapshot list in the management cluster, with sufficient information to request a restore.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #764
Special notes for your reviewer:
Checklist: