feat: add clusterclass exp feature scaffolding #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
force-pushed
the
clusterclass-operations-scaffold
branch
2 times, most recently
from
67f94d2 to
0c02b79
Compare
salasberryfin
changed the title
salasberryfin
force-pushed
the
clusterclass-operations-scaffold
branch
3 times, most recently
from
b7617aa to
998a92b
Compare
exp/clusterclass/internal/controller/clusterupgradegroup_controller.go
Outdated
Show resolved
Hide resolved
anmazzotti
requested changes
Dec 31, 2024
salasberryfin
force-pushed
the
clusterclass-operations-scaffold
branch
from
998a92b to
0f563b9
Compare
furkatgofurov7
approved these changes
Dec 31, 2024
anmazzotti
approved these changes
Dec 31, 2024
salasberryfin
force-pushed
the
clusterclass-operations-scaffold
branch
3 times, most recently
from
b3671a7 to
1e43aa4
Compare
Signed-off-by: Carlos Salas <[email protected]>
Signed-off-by: Carlos Salas <[email protected]>
Signed-off-by: Carlos Salas <[email protected]>
Signed-off-by: Carlos Salas <[email protected]>
Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
force-pushed
the
clusterclass-operations-scaffold
branch
from
1e43aa4 to
3947ffb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the scaffolding for the new experimental feature ClusterClass operations: you can read more about the proposal here.
For now, this is just scaffolding for adding the new logic to Turtles, specifically the controlled rollout of changes to cluster/s using the new CRD
ClusterUpgradeGroupdrawing inspiration from Fleet. Effectively this is a new controller that runs on a new pod (equivalent to what we're doing withexp/etcdrestore).This Controller is only deployed when using Tilt environment only (will be behind feature gate in subsequent iterations): image is created and controller pod deployed. No functionality is guaranteed yet.
When this is merged, we can start focusing on functionality, testing, etc. (issues are already available in this repository).
Which issue(s) this PR fixes:
Fixes #850
Special notes for your reviewer:
Checklist: