Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale upgrades: Flow rate and trickle timer #450

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

FabianSperrle
Copy link
Contributor

combine #436 and #437 into one PR.
Add fix for SCALE2_CALIBRATION_FACTOR initialization.

Switch to EMA smoothing

Finalization: Lower EMA a to 0.05 for stable readings, increase scale frequency to get high resolution, and prevent shot weights <0g
@FabianSperrle
Copy link
Contributor Author

Even though it's not super necessary, I kinda miss the flow rate now that I updated to the latest master.
Should I rebase this, maybe behind a feature flag, or just hack it in on my fork?

@LoQue90
Copy link
Member

LoQue90 commented May 23, 2024

I would say we could add this.
I'm only a bit concerned about the amount of stuff that will be shown on the display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants