Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this possibly useful? #144

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Is this possibly useful? #144

wants to merge 4 commits into from

Conversation

mom1
Copy link

@mom1 mom1 commented Aug 3, 2019

I made opportunity open a file in the current window from terminus
for example Traceback python:

Traceback (most recent call last):
  File "/home/user/.pyenv/versions/3.7.4/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/user/.pyenv/versions/3.7.4/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "client/__main__.py", line 13, in <module>
    from module import settings
ModuleNotFoundError: No module named 'module'

You can open each of files "/runpy.py", "/__main__.py"

I made opportunity open a file in the current view from terminus
for example Traceback python:
`
Traceback (most recent call last):
  File "/home/user/.pyenv/versions/3.7.4/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/user/.pyenv/versions/3.7.4/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "client/__main__.py", line 13, in <module>
    from module import settings
ModuleNotFoundError: No module named 'module'
`
@randy3k
Copy link
Owner

randy3k commented Aug 4, 2019

Thanks, it of course sounds useful. I will merge it once I have a chance to test it

 - Fix some bugs
 - separate logic
 - optimization
@rchl
Copy link

rchl commented Oct 18, 2019

Does this implementation also work for this case:

> rgl 'awk' ./node_modules/tib
./node_modules/tib/lib/tib-chrome.js
1199-        ' | grep -E -i \'(google chrome( canary)?|chromium)\\.app\\b\'' +

for opening ./node_modules/tib/lib/tib-chrome.js file?

@mom1
Copy link
Author

mom1 commented Oct 18, 2019

not yet

@rchl
Copy link

rchl commented Oct 18, 2019

OK. It would be nice to support that too then. :)

@rchl
Copy link

rchl commented Oct 18, 2019

Also another example - a stack from jest framework:

at ExecutionContext._evaluateInternal (node_modules/puppeteer-core/lib/ExecutionContext.js:122:13)

Both of those work in my terminal (iterm2) so it would be cool if those also worked in Terminus.

@mom1
Copy link
Author

mom1 commented Oct 21, 2019

at ExecutionContext._evaluateInternal (node_modules/puppeteer-core/lib/ExecutionContext.js:122:13)

This should be work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants