-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ldpaths
detection on macOS via DYLD_FALLBACK_LIBRARY_PATH
#417
Conversation
Attempts to address related issue #413 |
For reference, this patch is now applied in koopa: |
As indicated in the ldpaths file.
I thought that this trick no longer works for macOS >=10.11 with sip, apparently it is not the case? |
@randy3k That patch works on my Mac running Ventura 13.5 with SIP enabled. This is also a known issue with RStudio, which they're working to address in a new release: |
Oh, I think I have been misunderstanding the text in ldpaths for years. Actually it meant that we have to set the variable manually, the variable will not be passed automatically. Thanks for raising it. Will take a look later today :) |
@@ -75,35 +75,35 @@ def main(cleanup=None): | |||
if not r_home: | |||
raise RuntimeError("Cannot find R binary. Expose it via the `PATH` variable.") | |||
|
|||
if sys.platform.startswith("linux"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should still restrict ourself to non-window.
For example
if not sys.platform.startswith("win"):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed yeah that makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to do the edit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@randy3k Sure let me add that, 1 sec
This proposed pull request parses the
etc/ldpaths
file inR.home()
forDYLD_FALLBACK_LIBRARY_PATH
on macOS.I've confirmed that this works on my machine after testing with
python3 setup.py install
.Best,
Mike