New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for AA 0.6.1 #20

Open

alepore wants to merge 3 commits into randym:master from freego:master

alepore commented Oct 18, 2013

With AA 0.6.1 i get
undefined local variable or method max_csv_records' for #Admin::MyModelController:0x007fe69b29a278`

This is because the method was removed in this commit activeadmin/activeadmin@a8ad4f9
Using max_per_page should be the same, right?

Tests was green just because AA 0.6.0 was forced by Gemfile.lock.
I think it's a good practice do not include it in gems, read here: http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile

alepore added 3 commits

October 18, 2013 09:44


          Gemfile.lock should not be versioned

185e4b1

see http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/


          use max_per_page because max_csv_records was removed

576abfa


          fix rails version checking

82d06dd

thimios commented Jan 23, 2014

bumped on the same issue using AA 0.6.2 would be great to merge this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet