Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make comments work in office for mac 2015 #382

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lexxor
Copy link

@lexxor lexxor commented Mar 27, 2015

Hi!

Office for Mac 2015 don't show comments without 'xml:space' attribute.
Here is comments.xml extracted from xlsx file, created with Office:

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<comments xmlns="http://schemas.openxmlformats.org/spreadsheetml/2006/main">
  <authors><author>Пользователь Microsoft Office</author></authors>
  <commentList>
    <comment ref="C5" authorId="0">
      <text><r><rPr><b/><sz val="10"/><color indexed="81"/><rFont val="Calibri"/></rPr><t xml:space="preserve">test comment</t></r></text>
    </comment>
  </commentList>
</comments>

I can't test another office versions, but xlsx files exported from google docs also contains this attribute.

@randym
Copy link
Owner

randym commented Mar 27, 2015

Thanks lexxor.

Couple of quick questions:

Where did the changes in the xsd come from? We should be using the xsd from the documentation, so maybe there is an update out there we dont know about?

Can I trouble you to add specs proving that the xml:space attribute is added?

@lexxor
Copy link
Author

lexxor commented Mar 27, 2015

Unfortunately, I didn't find any updates related to xml:space attribute. And I was forced to modify xsd myself to make tests green.
I added some specs for xml:space attribute.
And I removed excess attribute. Excel doesn't add this attribute for author, only for comment text. It was my fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants