Thread safety fix #622
Closed
Thread safety fix #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> marshall-lee commented on 3 Aug 2016 > This PR aims to fix several issues with Relationship cache: > > 1. It's not threadsafe, so I propose to use a TLS variable for this. > 2. Memory obtained by cache remains non-freed before the next run of `serialize`. I think it should be freed immediately. > 3. Memory should be freed in `ensure` block to prevent memory bloating in case of exception. > > _There are only two hard things in Computer Science: cache invalidation and naming things._
adapted changes on `lib/axlsx/rels/relationship.rb` from centro@41ed34b
|
will close this, because it is updated in #477 now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry picked modifications from pending PR #477, to check if it works with current CI-settings