Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning for bold log text in Rails 7.2 #7

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

otegami
Copy link

@otegami otegami commented Aug 13, 2024

Replaced positional boolean arguments with option hashes for bolding log text using the color method.
This change addresses the following deprecation warnings in Rails 7.2, ensuring compatibility with future Rails versions.

Run bin/rails test
2024-08-08 23:47:05 INFO Selenium [:logger_info] Details on how to use and modify Selenium logger:
  https://selenium.dev/documentation/webdriver/troubleshooting/logging

2024-08-08 23:47:05 WARN Selenium [DEPRECATION] DriverFinder.path(options, service_class) is deprecated. Use DriverFinder.new(options, service).driver_path instead.
2024-08-08 23:47:06 WARN Selenium [DEPRECATION] DriverFinder.path(options, service_class) is deprecated. Use DriverFinder.new(options, service).driver_path instead.
DEPRECATION WARNING: Bolding log text with a positional boolean is deprecated and will be removed in Rails 7.2. Use an option hash instead (eg. `color("my text", :red, bold: true)`). (called from block in groonga at /home/runner/work/ranguba/groonga-client-model/lib/groonga_client_model/log_subscriber.rb:52)
DEPRECATION WARNING: Bolding log text with a positional boolean is deprecated and will be removed in Rails 7.2. Use an option hash instead (eg. `color("my text", :red, bold: true)`). (called from block in groonga at /home/runner/work/ranguba/groonga-client-model/lib/groonga_client_model/log_subscriber.rb:55)

ref: https://github.com/ranguba/ranguba/actions/runs/10311129722/job/28544124785

Replaced positional boolean arguments with option hashes for bolding log text using the `color` method.
This change addresses the deprecation warnings in Rails 7.2, ensuring compatibility with future Rails versions.
@abetomo
Copy link

abetomo commented Aug 13, 2024

Could you check the test as it is failing?

@otegami
Copy link
Author

otegami commented Aug 13, 2024

Sure I will check it. I'm going to make this PR draft because CI failed.

@otegami otegami marked this pull request as draft August 13, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants