Skip to content

Commit

Permalink
Add a reminder in set-trigger-rules script (microsoft#21929)
Browse files Browse the repository at this point in the history
### Description
After editing the set-trigger-rules.py, we must run the file.



### Motivation and Context
Obviously the script wasn't run because some files's name are incorrect.
  • Loading branch information
mszhanyi authored Aug 30, 2024
1 parent 02e3a43 commit 60b0762
Show file tree
Hide file tree
Showing 31 changed files with 36 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
1 change: 1 addition & 0 deletions tools/ci_build/github/azure-pipelines/mac-ci-pipeline.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
1 change: 1 addition & 0 deletions tools/ci_build/github/azure-pipelines/web-ci-pipeline.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
1 change: 1 addition & 0 deletions tools/ci_build/github/azure-pipelines/win-ci-pipeline.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
##### start trigger Don't edit it manually, Please do edit set-trigger-rules.py ####
### please do rerun set-trigger-rules.py ###
trigger:
branches:
include:
Expand Down
10 changes: 6 additions & 4 deletions tools/ci_build/set-trigger-rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
"orttraining-linux-gpu-ortmodule-distributed-test-ci-pipeline.yml",
"orttraining-mac-ci-pipeline.yml",
"win-ci-pipeline.yml",
"win-gpu-ci-dml-pipeline.yml",
"win-gpu-ci-cuda-pipeline.yml",
"win-gpu-ci-training-pipeline.yml",
"win-gpu-ci-doc-gen-pipeline.yml",
"win-gpu-dml-ci-pipeline.yml",
"win-gpu-cuda-ci-pipeline.yml",
"win-gpu-training-ci-pipeline.yml",
"win-gpu-doc-gen-ci-pipeline.yml",
"win-gpu-tensorrt-ci-pipeline.yml",
"win-qnn-arm64-ci-pipeline.yml",
"win-qnn-ci-pipeline.yml",
Expand All @@ -51,6 +51,8 @@ def add_trigger_filter(file_name, trigger_lines):

start_marker = f"##### start trigger Don't edit it manually, Please do edit {os.path.basename(__file__)} ####"
end_marker = "#### end trigger ####\n"
reminder = f"### please do rerun {os.path.basename(__file__)} ###"
trigger_lines.insert(0, f"{reminder}\n")

if lines[0].startswith(start_marker):
for i in range(1, len(lines)):
Expand Down

0 comments on commit 60b0762

Please sign in to comment.