-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implement deletion of singular contact + its tests, update documentation
- Loading branch information
Showing
12 changed files
with
73 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,9 @@ def __init__(self): | |
self.contacts = [] | ||
|
||
def create(self, contact): | ||
contact.id = uuid.uuid4().hex | ||
self.contacts.append(contact) | ||
return contact | ||
|
||
def find_all(self, user_id): | ||
return [contact for contact in self.contacts if contact.user == user_id] | ||
|
@@ -25,6 +27,10 @@ def delete_all(self, user_id): | |
self.contacts = [ | ||
contact for contact in self.contacts if contact.user != user_id] | ||
|
||
def delete_one(self, user_id, contact_id): | ||
self.contacts = [ | ||
contact for contact in self.contacts if not (contact.user == user_id and contact.id == contact_id)] | ||
|
||
|
||
class FakeUserRepository: | ||
def __init__(self, users=None): | ||
|
@@ -84,6 +90,17 @@ def test_delete_all(self): | |
contacts = self.contact_service.get_contacts(user.id) | ||
self.assertEqual(len(contacts), 0) | ||
|
||
def test_delete_one(self): | ||
user = User('testusername', 'testpassword', '123') | ||
contact = self.contact_service.create_contact( | ||
'Pekka', 'Pouta', '[email protected]', '123456789', 'Meteorologi', user.id) | ||
|
||
self.contact_service.delete_one(user.id, contact.id) | ||
|
||
contacts = self.contact_service.get_contacts(user.id) | ||
self.assertEqual(len(contacts), 0) | ||
print(len(contacts)) | ||
|
||
def test_create_contact_without_user(self): | ||
with self.assertRaises(NoUserError): | ||
self.contact_service.create_contact( | ||
|
@@ -93,6 +110,10 @@ def test_delete_all_without_user(self): | |
with self.assertRaises(NoUserError): | ||
self.contact_service.delete_all(None) | ||
|
||
def test_delete_one_without_user(self): | ||
with self.assertRaises(NoUserError): | ||
self.contact_service.delete_one(None, "1") | ||
|
||
def test_get_contacts_without_user(self): | ||
with self.assertRaises(NoUserError): | ||
self.contact_service.get_contacts(None) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters