Don't filter out DateTime values #357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all values other than string, int or float are filtered out in the
transformRowsmethod ofEportable. Since openspout does support DateTime values (see: https://github.com/openspout/openspout/blob/4.x/src/Writer/XLSX/Manager/WorksheetManager.php#L202-L203), we want to keep these values.Note that openspout/openspout probably needs some attention as well. DateTime values are converted to Excel-compatible Date values (floats), and while it is possible to apply a date formatting to all cells of all rows, that's probably not what you want since this might incorrectly apply the style non-date values that look like Excel-dates. I'll try to implement a fix for them that optionally allows to set a formatting per column.