Make it possible to wrapGApps without 4x wrapping #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also allows for more customisation in the mkDerivation
raphiz
reviewed
Jun 24, 2024
Signed-off-by: C0D3 M4513R <[email protected]>
C0D3-M4513R
force-pushed
the
main
branch
2 times, most recently
from
162a5cb to
b55e648
Compare
Signed-off-by: C0D3 M4513R <[email protected]>
|
@C0D3-M4513R Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allows for more customization in the mkDerivation
This is a follow-up pr to #19 for implementing Col-E/Recaf#805
4x wrapping, because wrapGApps will wrap the original script and then the wrapper, which sets JavaHome.
I let myself be inspired by how nixos's buildPythonApplication/mkPythonDerivation works.
Also sadly it was nessesary for me to statically set
dontWrapGApps=true.That itself should not be an issue, since the
gappsWrapperArgsdo get applied as they should inpostFixup.Please note, that this change does not make it required to use
wrapGAppsHook. It just makes it, so that everything works as best as possible, when it's specified.