This repository has been archived by the owner on Jun 17, 2022. It is now read-only.
Feature: type args support #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 93.26% 92.75% -0.52%
==========================================
Files 12 13 +1
Lines 193 207 +14
==========================================
+ Hits 180 192 +12
- Misses 13 15 +2
Continue to review full report at Codecov.
|
zkud
reviewed
Jun 21, 2021
| use crate::ir::ir_component::IRComponent; | ||
| use crate::parser::ast::traits::ast_term::ASTTerm; | ||
|
|
||
| pub struct TypeArgumentTerm { |
There was a problem hiding this comment.
Could we use a word dimension instead argument to describe the sense of this term?
zkud
reviewed
Jun 21, 2021
zkud
reviewed
Jun 21, 2021
zkud
reviewed
Jun 21, 2021
zkud
reviewed
Jun 21, 2021
Comment on lines
-11
to
+20
| let fields = vec![ | ||
| let mut fields = vec![ | ||
| ("name", self.name.generate_ir()), | ||
| ("type", self.type_name.generate_ir()), | ||
| ("hasDefault", Box::new(IRComponent::new_bool(false))), | ||
| ]; | ||
|
|
||
| if self.type_arguments.len() > 0 { | ||
| fields.push(("typeArguments", self.generate_type_arguments_ir())) | ||
| } |
There was a problem hiding this comment.
Could we extract fields building to a separate method, for instance, build_fields to make generate_ir do only one thing?
|
Hi @Arcimiendar, thank you for a pr, please check my comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add Number args to entity field types.
Example:
entity asdf {
someField: String(256),
someOtherField: Decimal(10, 3)
}