Use module cache for aux modules in RPC suggestions

lib/msf/core/rpc/v10/rpc_session.rb

@@ -465,20 +465,22 @@ def rpc_meterpreter_directory_separator(sid)
   # @example Here's how you would use this from the client:
   #  rpc.call('session.compatible_modules', 3)
   def rpc_compatible_modules( sid)
-    ret = []
-
-    mtypes = ['post', 'auxiliary']
-    mtypes.each do |mtype|
-      names = self.framework.send(mtype.to_sym).module_refnames.map{ |x| "#{mtype}/#{x}" }
-      names.each do |mname|
-        m = _find_module(mtype, mname)
-        if m.respond_to?(:session_compatible?) && m.session_compatible?(sid)
-          ret << m.fullname
-        end
-      end
+    # New cached module searching logic for aux modules
+    session_type = self.framework.sessions[sid].type
+    search_params = { 'session_type' => [[session_type], []], 'type' => [['auxiliary'], []] }
+    cached_aux_modules = Msf::Modules::Metadata::Cache.instance.find(search_params)
+    aux_module_fullnames = cached_aux_modules.each.map(&:fullname) || []
+
+    post_modules = []
+    mtype = "post"
+    names = self.framework.post.module_refnames.map{ |x| "post/#{x}" }
+    names.each do |mname|
+      m = _find_module(mtype, mname)
+      next if not m.session_compatible?(sid)
+      post_modules << m.fullname
     end
 
-    { "modules" => ret }
+    { "modules" => aux_module_fullnames + post_modules }
   end
 
 private