Add smb acceptance tests #19066
Merged
Add smb acceptance tests #19066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
Apr 8, 2024
adfoster-r7
reviewed
Apr 8, 2024
adfoster-r7
reviewed
Apr 8, 2024
adfoster-r7
reviewed
Apr 8, 2024
sjanusz-r7
force-pushed
the
add-smb-acceptance-tests
branch
2 times, most recently
from
07bebd8
to
cdce3b7
Compare
adfoster-r7
reviewed
Apr 10, 2024
sjanusz-r7
force-pushed
the
add-smb-acceptance-tests
branch
from
11bf682
to
7c39e9b
Compare
adfoster-r7
reviewed
Apr 19, 2024
spec/acceptance/smb_spec.rb
Outdated
Comment on lines
31
to
96
| { | ||
| name: "auxiliary/scanner/smb/smb_lookupsid", | ||
| platforms: [:linux, :osx, :windows], | ||
| targets: [:session, :rhost], | ||
| skipped: false, | ||
| lines: { | ||
| all: { | ||
| required: [ | ||
| "GROUP=None", | ||
| "USER=nobody", | ||
| "PIPE(LSARPC) LOCAL", | ||
| ], | ||
| }, | ||
| } | ||
| }, | ||
| { | ||
| name: "auxiliary/scanner/smb/pipe_auditor", | ||
| platforms: [:linux, :osx, :windows], | ||
| targets: [:session, :rhost], | ||
| skipped: false, | ||
| lines: { | ||
| all: { | ||
| required: [ | ||
| /Pipes: (\\([a-zA-Z]*)(, )?)*/, | ||
| ], | ||
| known_failures: [ | ||
| /Inaccessible named pipe:/, | ||
| /The server responded with an unexpected status code: STATUS_OBJECT_NAME_NOT_FOUND/, | ||
| ] | ||
| }, | ||
| } | ||
| }, | ||
| { | ||
| name: "auxiliary/scanner/smb/smb_enumshares", | ||
| platforms: [:linux, :osx, :windows], | ||
| targets: [:session, :rhost], | ||
| skipped: false, | ||
| lines: { | ||
| all: { | ||
| required: [ | ||
| "modifiable - (DISK)", | ||
| "readonly - (DISK)", | ||
| "IPC$ - (IPC|SPECIAL) IPC Service", | ||
| ], | ||
| }, | ||
| } | ||
| }, |
There was a problem hiding this comment.
If these are flakey because we need to update them to use ruby_smb, we can comment them out for now - and as we migrate modules to use ruby_smb we can bring back these tests as part of the ruby_smb support PR
adfoster-r7
reviewed
Apr 19, 2024
| end | ||
|
|
||
| ret = true | ||
| ret &&= stdout.buf.include?('recursive') |
There was a problem hiding this comment.
Not a blocker; these tests will be quite rigid - I wouldn't be able to run these tests against an arbitrary server for instance
sjanusz-r7
force-pushed
the
add-smb-acceptance-tests
branch
from
7c39e9b
to
1084be4
Compare
sjanusz-r7
force-pushed
the
add-smb-acceptance-tests
branch
from
1084be4
to
bf50da5
Compare
Release NotesAdds automated tests for multiple SMB modules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automated acceptance tests for SMB session & modules.
The steps for running the Docker container are:
Leaving in draft for now until the RubySMB timeout issue gets resolved.
Note: Trying to
sudo docker build .in a Kali VM results in:Verification
List the steps needed to make sure this thing works
SMB_USERNAME=acceptance_tests_user SMB_PASSWORD=acceptance_tests_password SPEC_OPTS='--tag acceptance' SPEC_HELPER_LOAD_METASPLOIT=false bundle exec rspec ./spec/acceptance/smb_spec.rb