Update create session default values #19069
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Metasploit RPC functionality to not open new SMB, Postgres, MySQL, MSSQL sessions by default.
The issue is caused by Metasploit's RPC exposing an
options
API with a default CreateSession value oftrue
. The RPC functionality does not take into consideration the Module'sDefaultOptions
key:There will be a separate effort to update the RPC layer to expose the default options to users correctly, but for now let's swap the default value in the module options itself
Verification
CreateSession
option asfalse