Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create aarch64-apple-darwin build script. #236

Closed
wants to merge 17 commits into from
Closed

Create aarch64-apple-darwin build script. #236

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6f927f3
Create aarch64-apple-darwin build script.
usiegl00 Oct 21, 2022
c9c3f0b
Add files via upload
Ishaanahuja7 Oct 31, 2022
aeb94a0
Add files via upload
Ishaanahuja7 Oct 31, 2022
43335ee
Update Makefile.json-c
Ishaanahuja7 Oct 31, 2022
da7fc65
Update Makefile.libsigar
Ishaanahuja7 Oct 31, 2022
7529b06
Update apple_mic.m
Ishaanahuja7 Nov 1, 2022
38a3067
Update apple_webcam.m
Ishaanahuja7 Nov 1, 2022
872a764
Update ARCHES
Ishaanahuja7 Nov 5, 2022
2a2a77d
Update darwin_sigar.c
Ishaanahuja7 Nov 5, 2022
e76c263
Update darwin_sigar.c
Ishaanahuja7 Nov 5, 2022
4b3e5b8
Update apple_mic.m
Ishaanahuja7 Nov 5, 2022
fc05835
Update apple_webcam.m
Ishaanahuja7 Nov 5, 2022
5d45912
Update apple_mic.m
Ishaanahuja7 Nov 5, 2022
cd67893
Merge branch 'ishaanahuja7_aarch64-mac-build-fixup' into aarch64-appl…
usiegl00 Nov 5, 2022
fc6bb49
Remove darwin_sigar.c as sigar was updated.
usiegl00 Nov 30, 2022
1a96cc8
Revert additions to ARCHES.
usiegl00 Dec 1, 2022
e7dedd0
Further revert additions to ARCHES.
usiegl00 Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ARCHES
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
i386-apple-darwin
x86_64-apple-darwin
aarch64-apple-darwin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion, darwin tuples are not currently built using the ARCHES pattern. Currently the ARCHES list builds only artifacts that can be cross compiled using a linux build system.

The gem build process currently calls the following in a macOS VM with Xcode available.

make TARGET=x86_64-apple-darwin
make TARGET=arm-iphone-darwin
make TARGET=aarch64-iphone-darwin

I do like the idea of having all supported tuples in the ARCHES file however the Makefile would need to be updated to either detect the running OS and skip darwin when run on a linux platform or darwin tuples need to be a separate file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note if removing is the path the other darwin added targets for iphone at the end of the file are also not compilable on Linux.

i686-w64-mingw32
x86_64-w64-mingw32
x86_64-linux-musl
Expand All @@ -12,3 +15,5 @@ mips-linux-muslsf
mipsel-linux-muslsf
mips64-linux-muslsf
s390x-linux-musl
arm-iphone-darwin
aarch64-iphone-darwin
Loading