Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow opting out of whitespace removal #68

Conversation

adfoster-r7
Copy link
Contributor

Update rex-text to support disabling whitespace stripping by default

@adfoster-r7 adfoster-r7 force-pushed the allow-opting-out-of-removing-whitespace branch from 968bb86 to 5e70ebd Compare February 16, 2024 17:56
@adfoster-r7 adfoster-r7 force-pushed the allow-opting-out-of-removing-whitespace branch from 5e70ebd to 67a084f Compare February 16, 2024 22:48
@adfoster-r7 adfoster-r7 changed the title Allow opting out of removing whitespace Allow opting out of whitespace removal Feb 16, 2024
@smcintyre-r7 smcintyre-r7 self-assigned this Feb 21, 2024
Copy link
Contributor

@smcintyre-r7 smcintyre-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. I was able to test this by using the framework side PR. Both the dns command and the search command appear to still be working correctly. I also see all unit tests have passed, so I'll go ahead and land this.

@smcintyre-r7 smcintyre-r7 merged commit 1ef344b into rapid7:master Feb 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants