-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.12.0 #211
Merged
Merged
Release v0.12.0 #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rator (#198) Contributes to rapidsai/dependency-file-generator#89 Resolves this warning I see in build and test CI jobs, coming from `rapids-dependency-file-generator`. > /opt/conda/lib/python3.9/site-packages/rapids_dependency_file_generator/cli.py:98: UserWarning: The use of --file_key is deprecated. Use -f or --file-key instead.
Update shared-workflows version to 24.10
We recently observed some issues with Python 3.12 + older `flake8` versions across RAPIDS: rapidsai/build-planning#101. This proposes updating all the pre-commit hooks in this repo (`pre-commit autoupdate`) to avoid such issues the next time someone comes to push new commits here. While doing this, I also discovered that wheel CI here was broken by rapidsai/shared-workflows#213 (see #205 (comment)). This fixes that as well.
Changes the `expansion-card.svg` code from `jp-icon0` class to `jp-icon3` which is more appropriate for sidebar/window icons in JupyterLab design style. Fixes #199 #### Light theme | Before | After | | -- | -- | | ![image](https://github.com/rapidsai/jupyterlab-nvdashboard/assets/5832902/0d660026-05ff-46d2-b3f2-82018a59c596) | ![image](https://github.com/rapidsai/jupyterlab-nvdashboard/assets/5832902/86817c02-751d-45c5-aeed-032a4700a31e) | #### Dark theme | Before | After | | -- | -- | | ![image](https://github.com/rapidsai/jupyterlab-nvdashboard/assets/5832902/8ace1694-a9d8-4053-8047-233f26e9362c) | ![image](https://github.com/rapidsai/jupyterlab-nvdashboard/assets/5832902/bccf43fa-5f51-4dcd-8713-1299864ccd11) | #### High contrast dark theme | Before | After | | -- | -- | | ![image](https://github.com/rapidsai/jupyterlab-nvdashboard/assets/5832902/db8e4eea-f767-4e64-8672-8a799e8baf0d) | ![image](https://github.com/rapidsai/jupyterlab-nvdashboard/assets/5832902/eeb6f36d-6561-4074-9bb0-550701c9a146) | Co-authored-by: Ajay Thorve <[email protected]>
## Description Contributes to rapidsai/build-planning#110 Proposes adding 2 types of validation on wheels in CI, to ensure we continue to produce wheels that are suitable for PyPI. * checks on wheel size (compressed), - *to be sure they're under PyPI limits* - *and to prompt discussion on PRs that significantly increase wheel sizes* * checks on README formatting - *to ensure they'll render properly as the PyPI project homepages* - *e.g. like how https://github.com/scikit-learn/scikit-learn/blob/main/README.rst becomes https://pypi.org/project/scikit-learn/*
PyNVML 12 will depend on nvidia-ml-py and drop its equivalent functionality. So it will largely become a metapackage with some utilities. This will mean using a much newer version of the NVML functionality through Python than is currently used in RAPIDS. As a preventive step, stick to PyNVML 11, which is what RAPIDS already uses. Then when PyNVML 12 is released, this can be relaxed on a project-by-project basis to see if it unconvers any issues that will need project-level fixes.
Adds a workflow that triggers a second workflow which sends a notification to a designated Slack channel on every PR labelled with breaking, whenever any of the following events are triggered on the PR: - closed - reopened - labeled - unlabeled Depends on rapidsai/shared-workflows#257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.