Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.12.0 #211

Merged
merged 9 commits into from
Nov 27, 2024
Merged

Release v0.12.0 #211

merged 9 commits into from
Nov 27, 2024

Conversation

raydouglass
Copy link
Member

No description provided.

raydouglass and others added 9 commits June 3, 2024 13:34
…rator (#198)

Contributes to
rapidsai/dependency-file-generator#89

Resolves this warning I see in build and test CI jobs, coming from
`rapids-dependency-file-generator`.

>
/opt/conda/lib/python3.9/site-packages/rapids_dependency_file_generator/cli.py:98:
UserWarning: The use of --file_key is deprecated. Use -f or --file-key
instead.
Update shared-workflows version to 24.10
We recently observed some issues with Python 3.12 + older `flake8`
versions across RAPIDS:
rapidsai/build-planning#101.

This proposes updating all the pre-commit hooks in this repo
(`pre-commit autoupdate`) to avoid such issues the next time someone
comes to push new commits here.

While doing this, I also discovered that wheel CI here was broken by
rapidsai/shared-workflows#213 (see
#205 (comment)).
This fixes that as well.
## Description

Contributes to rapidsai/build-planning#110

Proposes adding 2 types of validation on wheels in CI, to ensure we
continue to produce wheels that are suitable for PyPI.

* checks on wheel size (compressed),
  - *to be sure they're under PyPI limits*
- *and to prompt discussion on PRs that significantly increase wheel
sizes*
* checks on README formatting
  - *to ensure they'll render properly as the PyPI project homepages*
- *e.g. like how
https://github.com/scikit-learn/scikit-learn/blob/main/README.rst
becomes https://pypi.org/project/scikit-learn/*
PyNVML 12 will depend on nvidia-ml-py and drop its equivalent
functionality. So it will largely become a metapackage with some
utilities. This will mean using a much newer version of the NVML
functionality through Python than is currently used in RAPIDS. As a
preventive step, stick to PyNVML 11, which is what RAPIDS already uses.

Then when PyNVML 12 is released, this can be relaxed on a
project-by-project basis to see if it unconvers any issues that will
need project-level fixes.
Adds a workflow that triggers a second workflow which sends a
notification to a designated Slack channel on every PR labelled with
breaking, whenever any of the following events are triggered on the PR:

- closed
- reopened
- labeled
- unlabeled

Depends on rapidsai/shared-workflows#257
Copy link

copy-pr-bot bot commented Nov 27, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@raydouglass raydouglass merged commit f0e4f20 into main Nov 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants