Fix install download script and statically link nvrtc #452

trxcllnt · 2023-02-06T06:38:54Z

This PR fixes some of the issues identified in #451.

Updates to CMake 3.26-rc1 so we can statically link nvrtc
Updates to my fork of cmake-js so we can remove the custom nvidia-cmake-js wrapper script
Updates to the rapidsai-install-native-module download script:
- Throws an error when the requested CUDA version is lower than we support
- Sets an upper bound on CUDA major version, ensuring we still install on newer drivers
- Fixes an issue where require.resolve() fails if npx from npm v9 is run by yarn v1

I tested the package install process works in:

trxcllnt added 17 commits February 3, 2023 15:49

don't use npx

a30fa0a

use CMake 3.26 (with a patch) so we can statically link libnvrtc

af90dcc

organize workspace settings, ensure consistent vscode terminal cwd

e5f4c97

use npx again

9b2b342

fix install_native_module if using npm 9 and npx is run by yarn 1

7f64c6d

switch back to using npx regular style

2a87c3e

make npm install work on node v19.6.0 and npm v9.4.1

9efef64

update cmake-js to use my fork with fixes

8e4356d

don't need to include nvrtc_builtins_static

bc76b99

set lower and upper bounds on CUDA major version (currently both 11)

7041902

remove npm_config_nodedir testing override

baf5ebf

throw a helpful error message

c52bdee

update copyright year

3d89ff4

remove @rapidsai/core postinstall cmake-js script

29144ae

fix devel packages local build with new cmake-js

f79a43b

fix files list

a60a806

update lists of files that invalidate the images

a82cd91

trxcllnt merged commit 4343cc7 into rapidsai:main Feb 7, 2023

trxcllnt deleted the fix/install-script-npx branch February 7, 2023 02:00

Provide feedback