Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3 - Develop to Master #1511

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Version 3 - Develop to Master #1511

merged 6 commits into from
Nov 2, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Oct 31, 2023

Rename row-contents blades to collapsed-columns blades

by @lrljoe in #1519

Add Custom Filter Views

by @lrljoe in #1518

Search - Default to Live

Default search to "Live" behaviour rather than "Defer" to match V2
by @lrljoe in #1517

Filter DTOs

by @lrljoe in #1503
To improve both performance, and maintainability, DTOs are now used in place of passing a series of attributes to the Filter Render methods.
This will help consolidate the data being passed back and forth, and centralise the available data for a filter.

Split ConfigurableAreas, CollapsingColumns and TableAttributes

by @lrljoe in #1503
Split ConfigurableAreas, CollapsingColumns and TableAttributes into own Traits/Config/Helper Files for Maintainability by @lrljoe in #1514
The reason for this change is:

Reduces code-per-file, minimising potential for merge conflicts
Allows for easier location of code relevant for maintenance/bugs
Add "HasAllTraits" for Maintainability by @lrljoe in #1514
The reason for this change is:

To minimise number of Traits being added to DataTableComponent
To begin the process for allowing diverse Traits to be used (and thus minimising the codebase being laoded
In order to improve the maintainability of the package, splitting up certain functions is required.

This also supports work to migrate to ultimately migrate to v4.


All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

* Move ConfigurableAreas to Own Trait

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe lrljoe changed the title v3-Move ConfigurableAreas to Own Section WithConfigurableAreas (#1510) Version 3 - Develop to Master Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1511 (60cacf1) into master (2f07552) will increase coverage by 0.47%.
Report is 2 commits behind head on master.
The diff coverage is 97.70%.

@@             Coverage Diff              @@
##             master    #1511      +/-   ##
============================================
+ Coverage     88.08%   88.55%   +0.47%     
- Complexity     1251     1256       +5     
============================================
  Files            88       95       +7     
  Lines          3013     2980      -33     
============================================
- Hits           2654     2639      -15     
+ Misses          359      341      -18     
Files Coverage Δ
src/DataTableComponent.php 96.77% <100.00%> (+0.10%) ⬆️
src/DataTransferObjects/FilterGenericData.php 100.00% <100.00%> (ø)
src/Traits/ComponentUtilities.php 90.00% <ø> (ø)
...ts/Configuration/CollapsingColumnConfiguration.php 100.00% <100.00%> (ø)
...rc/Traits/Configuration/ComponentConfiguration.php 100.00% <ø> (ø)
...s/Configuration/ConfigurableAreasConfiguration.php 100.00% <100.00%> (ø)
src/Traits/Configuration/FilterConfiguration.php 94.11% <100.00%> (+0.50%) ⬆️
...aits/Configuration/TableAttributeConfiguration.php 100.00% <100.00%> (ø)
src/Traits/Helpers/CollapsingColumnHelpers.php 100.00% <100.00%> (ø)
src/Traits/Helpers/ComponentHelpers.php 98.07% <ø> (-0.98%) ⬇️
... and 19 more

@lrljoe lrljoe added the In Progress I've started diagnosing a fix label Oct 31, 2023
lrljoe and others added 2 commits November 1, 2023 21:08
…bleAttributes (#1514)

* Splitting ConfigurableAreas into Traits

* Splitting TableAttributes into Traits

* Splitting CollapsingColumns into Traits

* Add HasAllTraits Trait


---------

Co-authored-by: lrljoe <[email protected]>
* Initial Update - Using DTO

* Add filterGenericData

* Remove requirement for method on render for Filter

* Remove Render requirement

* GenericHeaderTest

* Add filter comparison

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe lrljoe requested a review from rappasoft November 1, 2023 21:29
* Update Search to Default Live

* Search Live Default - Test Fixes
@lrljoe lrljoe linked an issue Nov 1, 2023 that may be closed by this pull request
lrljoe and others added 2 commits November 2, 2023 00:05
* Add viewPath for Filters

* Update Filter ViewPath

* Add available methods for setCustomView

* Add Tests

* Migrate Column/Filter View properties to IsColumn & IsFilter traits to standardise

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Rename row-contents to collapsed-columns

* Update Change Log
@lrljoe lrljoe merged commit 94c5668 into master Nov 2, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Progress I've started diagnosing a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Search param is broken after V3 upgrade
1 participant