-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3 - Develop to Master #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move ConfigurableAreas to Own Trait --------- Co-authored-by: lrljoe <[email protected]>
lrljoe
changed the title
v3-Move ConfigurableAreas to Own Section WithConfigurableAreas (#1510)
Version 3 - Develop to Master
Oct 31, 2023
Codecov Report
@@ Coverage Diff @@
## master #1511 +/- ##
============================================
+ Coverage 88.08% 88.55% +0.47%
- Complexity 1251 1256 +5
============================================
Files 88 95 +7
Lines 3013 2980 -33
============================================
- Hits 2654 2639 -15
+ Misses 359 341 -18
|
…bleAttributes (#1514) * Splitting ConfigurableAreas into Traits * Splitting TableAttributes into Traits * Splitting CollapsingColumns into Traits * Add HasAllTraits Trait --------- Co-authored-by: lrljoe <[email protected]>
* Initial Update - Using DTO * Add filterGenericData * Remove requirement for method on render for Filter * Remove Render requirement * GenericHeaderTest * Add filter comparison --------- Co-authored-by: lrljoe <[email protected]>
* Update Search to Default Live * Search Live Default - Test Fixes
* Add viewPath for Filters * Update Filter ViewPath * Add available methods for setCustomView * Add Tests * Migrate Column/Filter View properties to IsColumn & IsFilter traits to standardise * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Rename row-contents to collapsed-columns * Update Change Log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename row-contents blades to collapsed-columns blades
by @lrljoe in #1519
Add Custom Filter Views
by @lrljoe in #1518
Search - Default to Live
Default search to "Live" behaviour rather than "Defer" to match V2
by @lrljoe in #1517
Filter DTOs
by @lrljoe in #1503
To improve both performance, and maintainability, DTOs are now used in place of passing a series of attributes to the Filter Render methods.
This will help consolidate the data being passed back and forth, and centralise the available data for a filter.
Split ConfigurableAreas, CollapsingColumns and TableAttributes
by @lrljoe in #1503
Split ConfigurableAreas, CollapsingColumns and TableAttributes into own Traits/Config/Helper Files for Maintainability by @lrljoe in #1514
The reason for this change is:
Reduces code-per-file, minimising potential for merge conflicts
Allows for easier location of code relevant for maintenance/bugs
Add "HasAllTraits" for Maintainability by @lrljoe in #1514
The reason for this change is:
To minimise number of Traits being added to DataTableComponent
To begin the process for allowing diverse Traits to be used (and thus minimising the codebase being laoded
In order to improve the maintainability of the package, splitting up certain functions is required.
This also supports work to migrate to ultimately migrate to v4.
All Submissions:
New Feature Submissions:
Changes to Core Features: