Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] Update dompurify 2.4.1 → 2.5.7 (minor) #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Oct 11, 2024


🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!


Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ dompurify (2.4.1 → 2.5.7) · Repo

Security Advisories 🚨

🚨 DOMpurify has a nesting-based mXSS

DOMpurify was vulnerable to nesting-based mXSS

fixed by 0ef5e537 (2.x) and
merge 943

Backporter should be aware of GHSA-mmhx-hmjr-r674 (CVE-2024-45801) when cherry-picking

POC is avaible under test

🚨 DOMPurify allows tampering by prototype pollution

It has been discovered that malicious HTML using special nesting techniques can bypass the depth checking added to DOMPurify in recent releases. It was also possible to use Prototype Pollution to weaken the depth check.

This renders dompurify unable to avoid XSS attack.

Fixed by 1e52026 (3.x branch) and 26e1d69 (2.x branch).

Release Notes

2.5.7

  • Fixed an issue with comment detection and possible bypasses with specific config settings, thanks @masatokinugawa
  • Removed the foreignObject element from the list of HTML entry-points, thanks @masatokinugawa

2.5.6

  • Fixed an issue with the execution logic of attribute hooks to prevent bypasses, thanks @kevin-mizu
  • Fixed a minor problem with the bower file pointing to the wrong dist path
  • Updated several development dependencies

2.5.4

  • Fixed a bug with latest isNaN checks affecting MSIE, thanks @tulach
  • Fixed the tests for MSIE and fixed related test-runner

2.5.0

  • Added new setting SAFE_FOR_XML to enable better control over comment scrubbing
  • Updated the LICENSE file to show the accurate year number
  • Updated several build and test dependencies

2.4.9

  • Fixed another conditional bypass caused by Processing Instructions, thanks @Ry0taK
  • Fixed the regex for HTML Custom Element detection, thanks @AlekseySolovey3T

2.4.8

  • Fixed two possible bypasses when sanitizing an XML document and later using it in HTML, thanks @Slonser

2.4.7

2.4.6

  • Fixed a bypass in jsdom 22 in case the noframes element is permitted, thanks @leeN

2.4.4

  • Added support for ALLOW_SELF_CLOSE_IN_ATTR flag, thanks @edg2s @AndreVirtimo
  • Added better support for shadowrootmode, thanks @mfreed7

2.4.3

  • Final release that is compatible with MSIE10 & MSIE 11

2.4.2

  • Fixed a Trusted Types sink violation with empty input and NAMESPACE , thanks @tosmolka
  • Fixed a Prototype Pollution issue discovered and reported by @kevin-mizu

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 63 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (95e0fb7) to head (5761651).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #102   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          134       134           
  Branches        28        28           
=========================================
  Hits           134       134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant