-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes for code #206
fixes for code #206
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Please see ch05/05_bonus_hparam_tuning/hparam_search.py
|
ch05/05_bonus_hparam_tuning/previous_chapters.py
Unexpected keyword argument class GPTDatasetV1(Dataset):
def __init__(self, txt, tokenizer, max_length, stride): |
appendix-E/01_main-chapter-code/previous_chapters.py keyword arg |
|
Thanks for the PR. And the CI failure is weird, I'll try to restart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good to me, thanks a lot!
I think the hparam Btw. great catch regarding the redundant |
Thanks a lot for checking and updating the code! |
GELU()
is inFeedForward()
func)tiktoken
not used)Please also see below comments, there are some issues that you might need to take a look into