Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note which settings pertain only to the bootloader... #3038

Merged
merged 8 commits into from
Aug 17, 2023

Conversation

srcshelton
Copy link
Contributor

… and so will only take effect if specified in config.txt.

See raspberrypi/firmware#1810 for discussion.

See raspberrypi/firmware#1810:

Document the settings which will be ignored if they are specified in any additional file which is included from `config.txt`.
Add notes for `start_file`, `fixup_file`, `start_x`, `start_debug`, `bootcode_delay`, `uart_2ndstage`.
Add notes for `gpu_mem`, `gpu_mem_256`, `gpu_mem_512`, `gpu_mem_1024`, `total_mem`.
Repeat of `start_file`/`fixup_file` was not intentional.
@@ -9,6 +9,8 @@ These options specify the firmware files transferred to the VideoCore GPU prior

NOTE: Cut-down firmware (`start*cd.elf` and `fixup*cd.dat`) cannot be selected this way - the system will fail to boot. The only way to enable the cut-down firmware is to specify `gpu_mem=16`. The cut-down firmware removes support for cameras, codecs and 3D as well as limiting the initial early-boot framebuffer to 1080p @ 16bpp - although KMS can replace this with up-to 32bpp 4K framebuffer(s) at a later stage as with any firmware.

NOTE: `start_file` and `fixup_file` are used by the bootloader, and so are only valid in `config.txt`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without any other context, I think these standalone NOTEs saying "only valid in config.txt" would be too confusing, given that they all appear on https://www.raspberrypi.com/documentation/computers/config_txt.html which is titled "The config.txt file".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess a link could be added to the section discussing includes - or does it just need to be made more specific by changing the end of the line to something along the lines of "… and so are not allowed in any additional included configuration file"?

The aim here is to avoid the confusion of including a file with these settings in, and then finding that they've not taken effect! 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it likely that anybody who's using config.txt includes will have read the section about config.txt include files, and so will have seen the list of settings that don't work in an included file? I'm reluctant to "pollute" the rest of the config.txt documentation with (potentially confusing) information that's only of benefit to a small proportion of users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page is called "config.txt" makes no sense to add notes like this, adds confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d6900bb removes the individual NOTEs.


*Include directives are not supported by the bootcode.bin or EEPROM bootloaders*.

Settings which are handled by the bootloader and so which will only take effect if they are specified in `config.txt` (rather than any additional included file) are:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to keep this bit where you document which settings don't work when used in an included file, as I suspect only a very small proportion of users actually use config.txt includes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a small note block about include files is okay. NOTES per individual items, not so much.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a small note block about include files is okay. NOTES per individual items, not so much.

d6900bb removes the individual NOTEs.

@aallan aallan added documentation waiting for revisions Waiting for the OP to make revisions labels Aug 4, 2023
@aallan aallan removed the waiting for revisions Waiting for the OP to make revisions label Aug 17, 2023
@aallan aallan merged commit 5696ef4 into raspberrypi:develop Aug 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants