Fix pin ordering for pins with names in pio_spi_flash #524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bi_4pins_with_names
does not have any ordering as it's a pin mask, so the pins must be in order, which cannot be guaranteed here depending on the default pins. This causes the names to appear next to the wrong pins inpicotool info
Eg for pico, with
picotool info -p
showsThis will throw a compilation error once pico-sdk/#1791 is merged, so this should be merged before that
Switch to 4 spearate
bi_1pin_with_name
to ensure the right name matches the right pin