Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation for PICO_BOARD=pico_w when cyw43_arch is missing #525

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix compilation for PICO_BOARD=pico_w when cyw43_arch is missing #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0dc6d16
Fix compilation for PICO_BOARD=pico_w when cyw43_arch is missing
lurch Aug 22, 2024
50d495d
Simplify things a bit
peterharperuk Aug 22, 2024
0c88be2
Fix message displayed when cyw43-driver is missing
peterharperuk Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ function(add_subdirectory_exclude_platforms NAME)
endfunction()

# Add blink example
add_subdirectory_exclude_platforms(blink)
if (PICO_CYW43_SUPPORTED AND NOT TARGET pico_cyw43_arch)
peterharperuk marked this conversation as resolved.
Show resolved Hide resolved
message("Wi-Fi driver is not available")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had meant "Skipping blink example as Wi-Fi driver is not available"

Can you also move this check into the blink CMakeLists.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also move this check into the blink CMakeLists.txt

By the time we're "in" the blink CMakeLists.txt, is it not then too late to call add_subdirectory_exclude_platforms(blink) ?

else()
add_subdirectory_exclude_platforms(blink)
endif()
add_subdirectory_exclude_platforms(blink_simple)

# Add hello world example
Expand Down
8 changes: 6 additions & 2 deletions adc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ if (TARGET hardware_adc)
add_subdirectory_exclude_platforms(joystick_display)
add_subdirectory_exclude_platforms(onboard_temperature)
add_subdirectory_exclude_platforms(microphone_adc)
add_subdirectory_exclude_platforms(read_vsys)
if (PICO_CYW43_SUPPORTED AND NOT TARGET pico_cyw43_arch)
message("Skipping read_vsys for Pico W as support is not available")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and fix this up to be "as Wi Fi driver is not available"

else()
add_subdirectory_exclude_platforms(read_vsys)
endif()
else()
message("Skipping ADC examples as hardware_adc is unavailable on this platform")
endif()
endif()
Loading