Add cmake script to update otp.json from privateaes.bin #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilograham
reviewed
Aug 27, 2024
| file(READ ${CMAKE_CURRENT_LIST_DIR}/privateaes.bin key_file HEX) | ||
| if (NOT ${key_file} STREQUAL "000102030405060708090a0b0c0d0e0f00102030405060708090a0b0c0d0e0f0") | ||
| message(WARNING | ||
| "Encrypted bootloader AES key not updated in otp.json file, as CMake version is < 3.19" |
There was a problem hiding this comment.
maybe this should be a fatal error?
There was a problem hiding this comment.
If this is a fatal error then I don't think it will work if the key file has been changed with older CMake versions, as this script gets run whenever the file is changed (and on first build), and on older CMake versions it has no way to parse the JSON file to check if the key in the JSON file matches the privateaes.bin file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, any changes to the key in privateaes.bin will not be reflected in the otp.json file, which could lead to issues if that is written to OTP.
This adds a cmake script using the JSON string handling to update the otp.json file if privateaes.bin is modified, before copying it to the binary directory. This fixes #528
This will not work on cmake versions prior to 3.19, as those don't support JSON string handling, so instead it throws a warning if the file has been changed. This should only throw the warning if privateaes.json has been changed from the default.