Add XIP cache maintenance API (fixes #2005) #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a cache clean to hardware_flash implementations, to avoid losing pending writes on the subsequent invalidate.
lurch
reviewed
Nov 4, 2024
lurch
reviewed
Nov 4, 2024
lurch
reviewed
Nov 4, 2024
lurch
reviewed
Nov 4, 2024
|
pls add new library to |
…f XIP_CACHE assertions on FLASH
will-v-pi
previously approved these changes
Nov 7, 2024
kilograham
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a cache clean to all
hardware_flashimplementations which flush the cache, to avoid losing cached PSRAM writes.This adds five new functions:
xip_cache_invalidate_all()xip_cache_invalidate_range()xip_cache_clean_all()(no-op on RP2040)xip_cache_clean_range()(no-op on RP2040)xip_cache_pin_range()(unavailable on RP2040)It uses offsets (
- XIP_BASE) instead of addresses, to be consistent with thehardware_flashAPIs. If anyone strongly disagrees then we should change it now before we're stuck with it.The library is unfortunately dependent on
hardware_sync, just to get the barrier macros.