Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for architecture ppc64le #115

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ddeka2910
Copy link

Include only php 7.1 and 7.2 for ppc64le.

Exclude php 5.4, 5.5, 5.6, 7.0, 7.3 for ppc64le as is it not available.
Only include php 7.1 and 7.2 for ppc64le
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddeka2910 This is an interesting one! 👍

Reposting from #114 because I don't see this answered anywhere: Afaict this package only contains userland PHP code that is not platform specific, so I'm not sure how relevant different architectures are here?

(On a side note: You can also push new changes to an existing PR instead of reopening a new one for each change)

@ddeka2910
Copy link
Author

For more info tag @gerrith3

@gerrith3
Copy link

@clue always a tough question - sometimes I answer with: can you prove that it runs on ppc64le without change? (btw, easy answer is yes, when it is running in travis ;-). But usually the issue with a project like this is the dependencies in your composer.json - are you sure that all of those dependencies and versions are available on ppc64le, thus enabling your package to be fully functional. Now, the testing that my team is doing before filing these indicates that yes, currently your dependencies are all available for ppc64le. There may be some differences in which versions of php are available (Power transitioned its Linux offerings to little endian (same as Intel) in 2016 - so versions of php build before then typically don't run on modern ppc64le. The testing and recommendations we make provide clarity as to exactly what build/run combinations actually do work out of the box.

I hope that helps, at least a bit on the justification.

@cboden
Copy link
Member

cboden commented Aug 14, 2021

With #124 we're now using GitHub CI instead of Travis. Can this PR be updated to target GH's CI file instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants