-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add version to CRD spec #1215
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1215 +/- ##
==========================================
+ Coverage 55.13% 55.15% +0.02%
==========================================
Files 104 104
Lines 6894 6902 +8
==========================================
+ Hits 3801 3807 +6
- Misses 2758 2760 +2
Partials 335 335 ☔ View full report in Codecov by Sentry. |
@binbin-li , i ve added some comments , please review when convenient, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This PR adds version property to the plugins CRD spec. Currently ratify doesn't not support loading different version of a plugin, however as we iterate on new version of external plugin, there is a need to ensure compatibility. If CR / config specifies version 2.0, and at runtime only v1 could be found, customer should be able to see the error in the log.
If version is not provided, it is set to a default version of 1.0.0. Since version property is optional, this change is backwards compatible.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Pending test:
Checklist:
Post Merge Requirements
Helm Chart Change