-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: design proposal for tag and digest co-existing [ISSUE 1657] #1793
Conversation
Hi @emalprokt thanks for the proposal! We have a community meeting tomorrow at 12:00 -1:00 AM (UTC), curious if you'd like to join. |
Hey @binbin-li |
Hi @akashsinghal @binbin-li , I've made changes to the proposal to have a enum style string Everything else is as is and as discussed in the meeting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the proposal.
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the proposal!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@emalprokt looks like the merge was blocked due to some commits were not signed. |
good catch, please follow the guide to sign the commit: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
@emalprokt could you help sign previous commits or squash them so that we can merge it? thanks! |
@emalprokt just checking in to see status on this PR and if you need any help signing off the commits. Looking forward to seeing the implementation PR :) |
Hi @akashsinghal @binbin-li I apologize for the long wait, I'll sign and merge this PR soon. We've moved this work to the next quarter so you'll have to wait just a little bit more for the implementation. |
@emalprokt thanks for signing the commits, could you help sign off the commits to pass the DCO check as well? |
Description
What this PR does / why we need it:
A design proposal for tag and digest to co-exist during mutation spec changes.
Proposal for the Ratify mutator to add new conditional feature to output a
tag@digest
image spec on top of the already existingdigest
.Issue here
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Proposes fix for #1657
Type of change
Please delete options that are not relevant.
main
branch)Checklist:
Post Merge Requirements
Helm Chart Change