Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: design proposal for tag and digest co-existing [ISSUE 1657] #1793

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

emalprokt
Copy link
Contributor

Description

What this PR does / why we need it:

A design proposal for tag and digest to co-exist during mutation spec changes.

Proposal for the Ratify mutator to add new conditional feature to output a tag@digest image spec on top of the already existing digest.

Issue here

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Proposes fix for #1657

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@binbin-li
Copy link
Collaborator

Hi @emalprokt thanks for the proposal! We have a community meeting tomorrow at 12:00 -1:00 AM (UTC), curious if you'd like to join.

@emalprokt
Copy link
Contributor Author

Hey @binbin-li
I'd love to join the meeting!
Thanks

docs/proposals/Tag-Digest-CoExist.md Outdated Show resolved Hide resolved
docs/proposals/Tag-Digest-CoExist.md Show resolved Hide resolved
docs/proposals/Tag-Digest-CoExist.md Show resolved Hide resolved
@akashsinghal akashsinghal changed the title Design Proposal for Tag and digest co-existing [ISSUE 1657] docs: design proposal for tag and digest co-existing [ISSUE 1657] Sep 11, 2024
@emalprokt
Copy link
Contributor Author

Hi @akashsinghal @binbin-li ,

I've made changes to the proposal to have a enum style string mutationStyle instead of the previously proposed retainTag.

Everything else is as is and as discussed in the meeting.

Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the proposal.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 131 files with indirect coverage changes

Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the proposal!

@binbin-li binbin-li enabled auto-merge (squash) September 12, 2024 05:30
Copy link
Collaborator

@junczhu junczhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junczhu
Copy link
Collaborator

junczhu commented Sep 12, 2024

@emalprokt looks like the merge was blocked due to some commits were not signed.
Would you squash all git commits into one and signing it?

@binbin-li
Copy link
Collaborator

@emalprokt looks like the merge was blocked due to some commits were not signed. Would you squash all git commits into one and signing it?

good catch, please follow the guide to sign the commit: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@junczhu junczhu enabled auto-merge (squash) September 14, 2024 04:22
@binbin-li
Copy link
Collaborator

@emalprokt could you help sign previous commits or squash them so that we can merge it? thanks!

@akashsinghal
Copy link
Collaborator

@emalprokt just checking in to see status on this PR and if you need any help signing off the commits. Looking forward to seeing the implementation PR :)

@emalprokt
Copy link
Contributor Author

Hi @akashsinghal @binbin-li I apologize for the long wait, I'll sign and merge this PR soon. We've moved this work to the next quarter so you'll have to wait just a little bit more for the implementation.

@susanshi susanshi modified the milestones: v1.4.0, v1.5.0 Oct 8, 2024
@binbin-li
Copy link
Collaborator

@emalprokt thanks for signing the commits, could you help sign off the commits to pass the DCO check as well?
image

@susanshi susanshi merged commit 12b4446 into ratify-project:dev Oct 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants