-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for crl basic functionality with built-in cache #1890
Conversation
Signed-off-by: Juncheng Zhu <[email protected]>
Thanks for the review and as discussed, I would use a wrapper to reuse the notation-core-go fetcher to save us from maintain work. |
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR JunCheng. In general i think we need to add more detail description on the method and input/output.
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Thank you for all the comments and I am working on them in the implementation PR #1900 |
Codecov ReportAttention: Patch coverage is
|
Pull request was converted to draft
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Hi @junczhu , in the PR description you mentioned "Under manual testing." Could you add the manual validation scenarios? thanks. |
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks Juncheng
Description
Enables CRL revocation with file cache during verification
What this PR does / why we need it:
The implementation is from notation cli covering CRL support CRL file-based cache support.
Removed HTTP timeout.
Related PR: notaryproject/notation#1043
Related File: https://github.com/notaryproject/notation/commits/main/cmd/notation/verify.go
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1889
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Manual test scenario: verify a signature with revocation check enabled.
Checklist:
Post Merge Requirements
Helm Chart Change