Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/2 mechanism to set span kind depending on operation name #211

Conversation

dkrizic
Copy link
Contributor

@dkrizic dkrizic commented Sep 8, 2024

  • Basic structure, but not implemented yet
  • Passing the spankindSelector
  • Test added

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.7%. Comparing base (453e0e0) to head (ede63a6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #211     +/-   ##
=======================================
+ Coverage   94.2%   94.7%   +0.4%     
=======================================
  Files          3       3             
  Lines        157     171     +14     
=======================================
+ Hits         148     162     +14     
  Misses         6       6             
  Partials       3       3             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ravilushqa
Copy link
Owner

The code looks good to me!
I’ve merged a smaller PR, which caused a test conflict in this one. Could you please resolve the conflict and address a small linter issue? Once those are fixed, it’ll be ready for merge, and I’ll follow up with a new release.

Thanks!

@dkrizic
Copy link
Contributor Author

dkrizic commented Sep 9, 2024

Yes, the two PRs are actually touching the same code, but since I made them independent, a conflict is expected. I will sync and update the PR.

BTW: assert.Equal expects first "expected", then "actual". I changed this in the one place.

…tion-name' of github.com:dkrizic/otelgqlgen into feature/2-mechanism-to-set-span-kind-depending-on-operation-name
@dkrizic
Copy link
Contributor Author

dkrizic commented Sep 9, 2024

The conflict has been resolved.

@ravilushqa
Copy link
Owner

The conflict has been resolved.

looks like something goes wrong an everything is failing now 😅

@dkrizic
Copy link
Contributor Author

dkrizic commented Sep 9, 2024

What do you mean? Can you fix the pipeline on main and I will update this branch.

@dkrizic
Copy link
Contributor Author

dkrizic commented Sep 9, 2024

I just see that the tests are failing on my side, I will update this

@dkrizic
Copy link
Contributor Author

dkrizic commented Sep 9, 2024

Tests are fix, the rest are your pipelines.

gqlgen.go Outdated Show resolved Hide resolved
@ravilushqa
Copy link
Owner

Thanks for your contribution!
I’ve taken care of the linter issue, and everything looks good to go now.

@ravilushqa ravilushqa merged commit 588d5cb into ravilushqa:main Sep 9, 2024
14 of 15 checks passed
@ravilushqa
Copy link
Owner

@dkrizic fyi
new version released https://github.com/ravilushqa/otelgqlgen/releases/tag/v0.17.0

@dkrizic dkrizic deleted the feature/2-mechanism-to-set-span-kind-depending-on-operation-name branch September 9, 2024 10:57
@dkrizic
Copy link
Contributor Author

dkrizic commented Sep 9, 2024

Grüsse aus Frankfurt nach Berlin.

@ravilushqa
Copy link
Owner

Grüsse aus Frankfurt nach Berlin.

I'm new in Berlin so
Mein Deutsch ist nicht besonders gut,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants