-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/2 mechanism to set span kind depending on operation name #211
feature/2 mechanism to set span kind depending on operation name #211
Conversation
dkrizic
commented
Sep 8, 2024
- Basic structure, but not implemented yet
- Passing the spankindSelector
- Test added
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
=======================================
+ Coverage 94.2% 94.7% +0.4%
=======================================
Files 3 3
Lines 157 171 +14
=======================================
+ Hits 148 162 +14
Misses 6 6
Partials 3 3 ☔ View full report in Codecov by Sentry. |
…ng-on-operation-name
The code looks good to me! Thanks! |
Yes, the two PRs are actually touching the same code, but since I made them independent, a conflict is expected. I will sync and update the PR. BTW: assert.Equal expects first "expected", then "actual". I changed this in the one place. |
…ng-on-operation-name
…tion-name' of github.com:dkrizic/otelgqlgen into feature/2-mechanism-to-set-span-kind-depending-on-operation-name
The conflict has been resolved. |
looks like something goes wrong an everything is failing now 😅 |
What do you mean? Can you fix the pipeline on main and I will update this branch. |
I just see that the tests are failing on my side, I will update this |
Tests are fix, the rest are your pipelines. |
Thanks for your contribution! |
@dkrizic fyi |
Grüsse aus Frankfurt nach Berlin. |
I'm new in Berlin so |