-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extra <span> after <Parametrize> #23
Comments
I don't really know what can be done about this - we need to wrap the component with something. What do you suggest as an alternative? Could you put it up as a PR? |
https://github.com/HubSpot/react-experiments/blob/master/src/parametrize.js#L72-L76 Does that return renderedChildren; |
afaik that'll be a problem since it wouldn't be wrapped in a parent element (similar to this issue: facebook/react#2127), but it's easy to try it out and you're probably right. I'll try to see if it's OK later today. |
if you simply remove the parent element you get the following error:
|
Oh right, I didn't consider that |
so the case is everytime i put injectedExperiment the component are wrapped with extra , i check it with react-dev-tools
The issue as in example
and this issue make the component styling a mess which is really annoying. my workaround for this are passing it from another component, so the experimentParams are passed from parent component.
The text was updated successfully, but these errors were encountered: