Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change element wrapper #24

Closed
wants to merge 2 commits into from
Closed

Change element wrapper #24

wants to merge 2 commits into from

Conversation

saveroo
Copy link

@saveroo saveroo commented Nov 23, 2016 •
edited
Loading

Regarding issue #23

using span sometimes break styling of wrapped element.

@saveroo saveroo closed this Nov 23, 2016
@saveroo saveroo reopened this Nov 23, 2016
@rawls238
Copy link
Owner

rawls238 commented Jan 6, 2017

I don't think this is the right way to go. A div causes many more style issues for users compared to a span.

@TrevorBurnham
Copy link

TrevorBurnham commented Jan 10, 2017 •
edited
Loading

@saveroo I don't understand how <span> is causing styling issues for you but <div> isn't. Do your project's stylesheets apply some sort of styling to all <span> elements?

@rawls238 rawls238 closed this Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saveroo @rawls238 @TrevorBurnham