chore(rax-swiper): enhance comments

raxjs · Jul 20, 2023 · 1632112 · 1632112
1 parent 1ebaa32
commit 1632112
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 6 deletions.
diff --git a/packages/rax-swiper/src/web/init-swiper.js b/packages/rax-swiper/src/web/init-swiper.js
@@ -6,9 +6,17 @@ import { needsNavigation, needsPagination, needsScrollbar } from './utils';
 // both support webpack 4 and 5 resolving rule.
 import 'swiper/swiper-bundle.min.css';
 
-// TODO: Support SSR in Swiper component of HyperKit
-// A temporary solution to prevent swiper.js errors under SSR
-document.documentElement.style = document.documentElement.style || {};
+/**
+ * TODO: Support SSR in Swiper component of HyperKit.
+ * Temporary solution to prevent swiper.js errors under SSR.
+ *
+ * Swiper.js use ssr-window under the hood, which ensure `document` is defined.
+ * So we need to ensure `document.documentElement` and `document.documentElement.style` only.
+ */
+if (!document.documentElement?.style) {
+  document.documentElement = document.documentElement || {};
+  document.documentElement.style = document.documentElement.style || {};
+}
 
 Swiper.use([Autoplay, Pagination]);
 function initSwiper(swiperParams) {

diff --git a/packages/rax-view/tsconfig.json b/packages/rax-view/tsconfig.json
@@ -17,8 +17,13 @@
     "noImplicitThis": false,
     "outDir": "lib",
     "baseUrl": ".",
-    "allowSyntheticDefaultImports": true
+    "allowSyntheticDefaultImports": true,
   },
-  "include": ["src/**/*"],
-  "exclude": ["node_modules", "lib"]
+  "include": [
+    "src/**/*"
+  ],
+  "exclude": [
+    "node_modules",
+    "lib"
+  ]
 }